Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classify a ConnectTimeout as RequestTimedOut #1653

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Classify a ConnectTimeout as RequestTimedOut #1653

merged 1 commit into from
Apr 19, 2022

Conversation

MihaZupan
Copy link
Member

Fixes #1628

RequestTimedOut is described as

Timed out when trying to connect, send the request headers, or receive the response headers.

So a ConnectTimeout fits this existing description.

cc: @davidni

@MihaZupan MihaZupan added this to the YARP 1.1.0 milestone Apr 13, 2022
@MihaZupan MihaZupan requested a review from Tratcher as a code owner April 13, 2022 13:05
@davidni
Copy link
Contributor

davidni commented Apr 14, 2022

Thanks @MihaZupan, works for us!

@MihaZupan MihaZupan merged commit 44a962f into microsoft:main Apr 19, 2022
@nlyu
Copy link

nlyu commented Apr 27, 2022

@MihaZupan Hi thx for the fix. When would this be released?

@MihaZupan
Copy link
Member Author

It's available in daily builds.
Otherwise, it will be included in the 1.1 release, which is likely going to be released within a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
YARP 1.1.0
Development

Successfully merging this pull request may close these issues.

ConnectTimeout bubbles out imprecisely as RequestCanceled
4 participants
@MihaZupan @davidni @nlyu @Tratcher